Repository navigation
ci: run check-orphans and bench on moc 2.0.0 too - #564
Merged
Merged
Conversation
matchers 2.1.1 compiles on moc 2, so `mops check`, which also type-checks every dependency, no longer fails on it. Bump the dev-dependency and give check-orphans and bench the same moc matrix axis as test and validate-docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Motoko job in CI now also runs on moc 2.0.0:
check-orphansandbenchjointestandvalidate-docs. Follow-up to #557.They couldn't before because
mops checkpasses--all-libs, which type-checks every file of every dependency.matchers2.1.0 has an= async { ... }body inCanister.mothat moc 2 rejects (M0277), socheck:orphansandcheck:benchfailed even though nothing here imports that file.matchersnow lives in caffeinelabs/mops-packages, and 2.1.1 drops the redundantasync.Locally,
check:orphans,check:bench,test:mops(675 tests), andbench(8 benchmarks) pass on both the pinned moc 1.16.0 and 2.0.0.What is unchanged
testcheck keeps its name. Onlycheck-orphansandbenchchange tocheck-orphans (moc …)andbench (moc …), and neither is required by the ruleset.🤖 Generated with Claude Code