Use the manual hook stage if it exists in the list#597
Closed
ThunderKey wants to merge 1 commit into
Closed
Conversation
Otherwise, installStages = [ "pre-push" "manual" ] will not use a --hook-stage and use the commit stage. In pre-commit the commit stage is the default hook stage
|
I am experiencing the same issue and it seems to be fixing the problem. |
Member
|
Superseded by #689. Will give you an option to control which stage to run as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #415 seems not maintained anymore and it hinders our workflow I've created a simple workaround.
The issue is, that
pre-commitwithout a--hook-stageuses thecommitstage.Now we have
["pre-push" "manual"]as theinstallStagesdefined.Because of that it does not match the current
compareand which lead to the the commit stage being used., which contains no tasks.This change uses the
manualstage if it exists anywhere in theinstallStageslist.