Skip to content

Make it posible to override pre-commit binary #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domenkozar merged 2 commits into from
Oct 7, 2025
Merged

Make it posible to override pre-commit binary #2204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a10932
Make it posible to override pre-commit binary
leiserfg Oct 7, 2025
45e0bbb
Use the original binary name
leiserfg Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/modules/integrations/git-hooks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ let
# This affects all packages built with `buildPythonApplication` or `toPythonApplication`.
# pre-commit is particularly annoying as it is difficult for end-users to track down.
# Tracking: https://github.com/NixOS/nixpkgs/issues/302376
packageBin = pkgs.runCommandLocal "pre-commit-bin" { } ''
packageBin = pkgs.runCommandLocal "pre-commit-bin" { meta.mainProgram = cfg.package.meta.mainProgram; } ''
mkdir -p $out/bin
ln -s ${cfg.package}/bin/pre-commit $out/bin/pre-commit
ln -s ${lib.getExe cfg.package} $out/bin/${cfg.package.meta.mainProgram}
'';

anyEnabled = builtins.any (hook: hook.enable) (lib.attrValues cfg.hooks);
Expand All @@ -35,7 +35,7 @@ in
(git-hooks-module + "/modules/all-modules.nix")
{
rootSrc = self;
package = pkgs.pre-commit;
package = lib.mkDefault pkgs.pre-commit;
tools = import (git-hooks-module + "/nix/call-tools.nix") pkgs;
}
];
Expand Down Expand Up @@ -94,7 +94,7 @@ in
before = [ "devenv:enterShell" ];
};
"devenv:git-hooks:run" = {
exec = "pre-commit run -a";
exec = "${packageBin.meta.mainProgram} run -a";
before = [ "devenv:enterTest" ];
};
};
Expand Down