refactor: rename SerializationWrapper methods to be backend-agnostic - #28
Merged
Merged
Conversation
Remove Redis-specific naming from the generic serialization wrapper: - wrap_for_redis() → wrap() - unwrap_from_redis() → unwrap() The SerializationWrapper creates a JSON envelope with base64-encoded payload - this format is backend-agnostic and works with any cache backend (Redis, CachekitIO, Memcached, etc.). The "redis" naming was a historical artifact that incorrectly implied Redis coupling. Also updated related docstrings/comments in cache_handler.py to use "cache" instead of "Redis" for consistency. Pre-commit fix: Use venv basedpyright directly with --level error to avoid uv.lock modification and match Makefile behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializationWrapperwrap_for_redis()→wrap()unwrap_from_redis()→unwrap()cache_handler.pyto use "cache" instead of "Redis"The
SerializationWrappercreates a JSON envelope with base64-encoded payload - this format is backend-agnostic and works with any cache backend (Redis, CachekitIO, Memcached, etc.). The "redis" naming was a leaky abstraction.Pre-commit fix
Also fixes the basedpyright pre-commit hook to:
.venv/bin/basedpyright) instead ofuv runto avoid modifyinguv.lock--level errorto match Makefile behavior (fail on errors only, not warnings)Test plan
make quick-checkpasses