Skip to content

Add link to Cranelift Examples #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 2 commits into from
Jun 3, 2025
Merged

Add link to Cranelift Examples #10912

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c91bc
Add link to Cranelift Examples
simvux Jun 3, 2025
c8233d2
clarify that Cranelift Examples is third-party maintained
simvux Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cranelift/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ For an example of how to use Cranelift to run WebAssembly code, see

[Wasmtime]: https://github.com/bytecodealliance/wasmtime

For various examples of how to use Cranelift to accomplish common compiler
tasks, see the [Cranelift Examples] repository.
Copy link
Copy Markdown
Member

@cfallin cfallin Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a little more explicit about the third-party maintenance -- perhaps something like "For various examples of how to use Cranelift to accomplish common compiler tasks, in addition to the above, @simvux maintains a [Cranelift Examples] repository." ?

Copy link
Copy Markdown
Contributor Author

@simvux simvux Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Although not sure about the wording. "in addition to above" could be misinterpreted as me maintaining the JIT demo.

Copy link
Copy Markdown
Member

@cfallin cfallin Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sure, I had just meant to indicate that it's another set of examples, but no need for that phrase I suppose.

Copy link
Copy Markdown
Contributor Author

@simvux simvux Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just

For various examples of how to use Cranelift to accomplish common compiler
tasks, see the [Cranelift Examples] repository maintained by @simvux.

Copy link
Copy Markdown
Member

@cfallin cfallin Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!


[Cranelift Examples]: https://github.com/simvux/cranelift-examples

Status
------

Expand Down