Skip to content

Interleave benchmark iterations from different processes #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fitzgen wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Interleave benchmark iterations from different processes #143

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ee07d9
Always spawn subprocesses for recording benchmarks
fitzgen Jun 4, 2021
489641e
Interleave benchmark iterations from different processes
fitzgen Jun 4, 2021
3b3dea7
Give `anyhow` dependency an actual version
fitzgen Jun 4, 2021
a780663
Ensure that the first iteration doesn't happen concurrently with chil…
fitzgen Jun 4, 2021
42d3f5c
Flush stdout/child-stdin when we write newlines into them
fitzgen Jun 4, 2021
0ab7209
CI: set the `RUST_LOG` level to `debug`
fitzgen Jun 9, 2021
f6ca5d4
Add more logging for IPC protocol
fitzgen Jun 9, 2021
cf7cfce
CI: only run `cargo test` not `cargo build`
fitzgen Jun 9, 2021
534c79c
CI: Don't capture stdout/stderr and run single threaded
fitzgen Jun 9, 2021
4b5a70b
Log stdout/stderr for `sightglass-cli` test commands
fitzgen Jun 10, 2021
726979e
Read children's stdout before waiting on them to exit
fitzgen Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/sightglass.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
CARGO_TERM_COLOR: always
RUST_LOG: info
RUST_LOG: debug

# The Wasmtime commit that we build the bench API from for testing. Bumping
# this will automatically cause us to update our CI cache on the next run.
Expand Down Expand Up @@ -73,8 +73,5 @@ jobs:
if: runner.os == 'Windows'
run: echo "SIGHTGLASS_TEST_ENGINE=$(pwd)\\wasmtime\\target\\release\\wasmtime_bench_api.dll" >> $env:GITHUB_ENV

- name: Build all
run: cargo +nightly build --verbose --all

- name: Test all
run: cargo +nightly test --verbose --all
run: cargo +nightly test --verbose --all -- --nocapture --test-threads 1
Loading