PR #3 - Refactor: .NET Standard 2 -> .NET 10 to prep for Newtonsoft rewrite#96
Open
AlexanderJohnston wants to merge 25 commits into
Open
PR #3 - Refactor: .NET Standard 2 -> .NET 10 to prep for Newtonsoft rewrite#96AlexanderJohnston wants to merge 25 commits into
AlexanderJohnston wants to merge 25 commits into
Conversation
- Write to the client stream whether or not the checkpoint write succeeds - Do not ignore events routed to stopped flows - Avoid a null reference when an existing flow fails to load
The SkipException handling that required await was removed in a prior commit. Simplify back to returning the task directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Feature/dotnet10 upgrade
Feature/grpc cleanup
AlexanderJohnston
changed the title
AlexanderJohnston
changed the title
AlexanderJohnston
changed the title
AlexanderJohnston
changed the title
AlexanderJohnston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the four core library projects from
netstandard2.0tonet10.0, completing the framework modernization started in the previous upgrade cycle. This resolves the split-TFM architecture and enables the use of modern .NET 10 features throughout the codebase.Changes
Project Target Framework Upgrades
netstandard2.0→net10.0)netstandard2.0→net10.0)netstandard2.0→net10.0)netstandard2.0→net10.0)Package Reference Upgrades (Totem.Runtime & Totem.Timeline)
Microsoft.Extensions.Configuration.Binder: 2.2.0 → 10.0.0Microsoft.Extensions.DependencyInjection.Abstractions: 2.2.0 → 10.0.0Microsoft.Extensions.Hosting.Abstractions: 2.2.0 → 10.0.0Microsoft.Extensions.Logging.Abstractions: 2.2.0 → 10.0.0Microsoft.Extensions.Options: 2.2.0 → 10.0.0Code Changes
fieldtofin theNamesproperty to avoid C# 14 keyword conflictfieldis now a reserved keyword for synthesized backing fieldsConfiguration Changes
LangVersion 7.1from all four projects (now uses C# 14 default)Impact
✅ Non-Breaking: All downstream projects (already on
net10.0) continue to build successfully✅ NuGet Compatibility: Projects continue to build as NuGet packages
✅ Clean Build: 0 errors, 1 pre-existing warning (SYSLIB0050 on FormatterServices - tracked separately)
Architecture Benefits
This upgrade:
net10.0)Microsoft.Extensions.*version mismatch (was 2.2.0 in core, 10.0.0 in apps)Testing