Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 of 8 tasks
Owner
Author
|
Included in #454, merged as b6f4e75. The commits from reviewed head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Web UI E2E daemon could not bind its socket under the default macOS temporary directory. Long
TMPDIRand--bench-homepaths also broke standalone daemon equivalence checks.What changed
Choose a temporary parent that keeps the longest E2E socket path within the macOS Unix-socket limit. Keep the configured temporary directory when it is short enough, and otherwise use
/tmp. Windows keeps its configured temporary directory because its daemon uses a TCP port file. The Web UI script still reports the actual retained directory with--keep-tmp. The CI ShellCheck command checks the shared temporary-directory helper.For standalone daemon equivalence, use a private temporary alias when the requested home has an overlong socket path. Artifacts stay in the requested home. Worktree daemon homes also use a socket-safe temporary parent.
To reproduce with the web dependencies and Playwright Chromium installed:
Validation
python3 -m unittest discover -s tests -p test_e2e_workflow.py,python3 -m unittest discover -s tests -p test_check_daemon_equivalence.py, and ShellCheck cover the temporary-directory helpers and changed scripts. On macOS, the initial revision completedscripts/e2e_all.sh --binary <release-binary>with an overlongTMPDIR, including CLI, daemon, and headless Web UI acceptance. The standalone Web UI acceptance also completed with the host's defaultTMPDIRand--keep-tmp. Standalone daemon equivalence completed with an overlong multibyte temporary path, both with its default home and with an explicit--bench-home. The Rust suite was not rerun on this branch alone because this change only affects test infrastructure. Windows execution was not available locally.A temporary worktree combined the code changes from the three PR branches. It ran
cargo test --locked --test skip_gitignore --test literal_cli, both E2E infrastructure unit-test modules, andscripts/e2e_all.sh --binary <debug-binary>with an overlongTMPDIR. The browser used one headless worker.The dependency audit fails on the unchanged main-branch lockfile because of existing
rustlsandzipadvisories.Evidence
Not applicable.
Risk
When a Unix temporary path is too long, the shell E2E artifacts use
/tmpinstead of the requested parent. Standalone daemon equivalence retains artifacts in its requested home and removes its private socket alias after stopping the daemon. The temporary directories remain private. The scripts fail if no suitable temporary parent is available. Revert the change to restore the previous temporary path selection.Checklist
./test.sh --quickpassed during iteration../test.shpasses, or Validation explains narrower proportional checks.