Repository navigation
[fix] Remove deleted sources from search - #452
Merged
Merged
Conversation
Certify indexed inputs before clean-checkout reuse, reconcile legacy markers, and apply explicit watcher deltas. Exclude confirmed-missing sources from fresh and cached results before relevance filtering. Cover worktree tombstones and restoration, require daemon mutation correctness in CI, and correct documentation of merge-base behavior and unreleased safeguards.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56a4de2f03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use successful metadata only to establish that absence is unconfirmed. Errors still require contained NotFound confirmation, and opened Unix readers preserve their pinned root identity. Cover deletion, restoration, unsafe paths, and replaced roots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recurring stale-deletion evidence in #441 includes a deleted file in SQLite and the Merkle snapshot, returned by an uncached query. The clean-checkout shortcut could certify transient source content even when both Git checks saw the same clean tree, then suppress reconciliation.
What changed
Validation
./test.sh: passed on430286c, including formatting, ShellCheck, Clippy, frontend checks/build, Rust library/binary/integration tests, and Python harness tests.cargo build --release --locked: passed on430286c. Focused workspace-file, cached-search, deletion, overlay, unsafe-fallback, and all-indices regressions also passed.uv run scripts/soak_daemon.py --binary <built-ig> --correctness-only --output <report>: passed with the final default release binary and current-head hash-only CI binary. Cached and uncached deleted stages return no hits; the stores reconcile and inherited deletions retain tombstones.Evidence
Deterministic tracked edit/read/restore and untracked create/read/delete fixtures failed before the fix with
a transient indexed source was certified as current, then passed after it. Search regressions also reproduced missing files occupying result limits and raising the relevance cutoff enough to suppress a live result.A cached
limit=1search with two matches failed before the cache refill fix withcached deletion lost the live runner-up, then passed after recomputation was added. The regression also verifies unchanged warm-cache reuse and reuse of the refreshed result.The final paired CI report compares main
048fc938with the synthetic merge of430286c. Its source tree matches the reviewed head exactly. Cache-replay p95 ratio is 1.126, with a 95% interval of 1.081 to 1.151. The existing guard rejects a regression whose confidence lower bound exceeds 1.10, so this passes the guard while retaining measurable overhead. No speedup or latency equivalence is claimed.Risk
Existing clean markers require reconciliation once. Certification checks snapshot paths and source metadata when recording a reusable state; unchanged certified indexing retains its shortcut. Live query filtering checks file presence on every request, treats only contained
NotFoundas deletion, and adds measured cache latency. Further cache-path tuning remains a performance follow-up. Explicit Git-history context can still include deleted content labeledgit_deleted. The fix and home/root confirmation safeguard remain unreleased relative to v1.3.0.Checklist
./test.sh --quickpassed during iteration../test.shpasses, or Validation explains narrower proportional checks.