Repository navigation
Conversation
Afloat16
marked this pull request as ready for review
October 14, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepMimic's relative angular velocity can follow a different quaternion arc from its interpolated pose. Yaw −2 → +2 radians over 0.1 seconds produces +40 radians/second in ComputeAngVelRel, while native getQuaternionSlerp follows the shortest arc at approximately −22.83185 radians/second.
Let native SLERP select the endpoint hemisphere, then use independently normalized endpoints to obtain its geometric midpoint. Derive the half-arc angle with atan2, rotate the bounded angular displacement into the start body frame, and divide by the duration in Python. Apply the same fix to the copied Humanoid and Quadruped helpers. World-frame angular velocity, scalar joints and public signatures are unchanged.
Validation on Python 3.11.13, NumPy 2.3.5 and the official unchanged PyBullet 3.2.7 native binding:
The C++ extension was not changed or rebuilt. Whole C++/OpenCL/GUI and Gym/TensorFlow training suites were not run; no training or performance result is claimed. Production norm calls retain two-argument math.hypot compatibility, but native testing here covers Python 3.11 only.