fix(registry): fix yank buildpack issue body template#2626
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(registry): fix yank buildpack issue body template#2626AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
type/enhancement
AruneshDwivedi
force-pushed
the
fix/yank-buildpack-template
branch
from
0bbca00 to
031994d
Compare
The GithubIssueBodyTemplate was missing yank = true when Yanked is true, and was missing triple backtick code block delimiters. The template now correctly outputs 'yank = true' for yanked buildpacks and wraps the body in triple backticks. Fixes buildpacks#2461 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com> Assisted-by: OWL Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix/yank-buildpack-template
branch
from
031994d to
879a65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2461. The
pack buildpack yankcommand generated an invalid GitHub issue body — it was missingyank = truewhen the buildpack is yanked, and the body was missing triple backtick code block delimiters.Root Cause
In
internal/registry/registry_cache.go, theGithubIssueBodyTemplatehad two bugs:.Yankedis true, the template output nothing (empty{{ if .Yanked }}{{ else }}...)Fix
{{ if .Yanked }}{{ else if .Address }}to{{ if .Yanked }}yank = true{{ else if .Address }}Testing
The generated issue body now correctly includes
yank = truefor yanked buildpacks and is properly wrapped in a code block.