Skip to content

feat: log warning if unable to validateRunImageConfig for whatever er…#2622

Open
wilsonfv wants to merge 1 commit into
buildpacks:mainfrom
wilsonfv:main
Open

feat: log warning if unable to validateRunImageConfig for whatever er…#2622
wilsonfv wants to merge 1 commit into
buildpacks:mainfrom
wilsonfv:main

Conversation

@wilsonfv

@wilsonfv wilsonfv commented Jun 1, 2026

Copy link
Copy Markdown

Summary

As discussed in #2584, during pack builder create, if pack is unable to run validateRunImageConfig against run-image, it should not return error and fail the build instead pack should log warning and continue the build for whatever reason run-image is not able to verify and leave run-image verification back to user during pack build

func (c *Client) validateConfig(ctx context.Context, opts CreateBuilderOptions, target *dist.Target) error {
if err := pubbldr.ValidateConfig(opts.Config); err != nil {
return errors.Wrap(err, "invalid builder config")
}
if err := c.validateRunImageConfig(ctx, opts, target); err != nil {
return errors.Wrap(err, "invalid run image config")
}
return nil
}

Resolves #2584

@wilsonfv wilsonfv requested review from a team as code owners June 1, 2026 12:06
@github-actions github-actions Bot added this to the 0.41.0 milestone Jun 1, 2026
@github-actions github-actions Bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 1, 2026
…ror returned (buildpacks#2584)

Signed-off-by: Wilson Mo <wilsonfv@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opt-out validateRunImageConfig when creating builder

1 participant