Added build container MAC address support#2620
Open
TIR44 wants to merge 1 commit into
Open
Conversation
Signed-off-by: TiR <70480807+TIR44@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pack build --mac-addressflag and passed it throughclient.BuildOptions.ContainerConfig.NetworkingConfig.EndpointsConfigfor the selected build container network.NetworkingConfigwhen a MAC address is configured.Output
Before
pack buildhad no way to pass a MAC address to the build container network endpoint.After
pack build --mac-address 01:23:45:67:89:ab ...validates the address and creates lifecycle containers with that MAC address on the configured network endpoint.Documentation
Related
Resolves #1779
Tests
go test ./internal/build -run '^TestPhaseConfigProvider$' -count=1go test ./internal/commands -run '^TestBuildCommand$' -count=1go test ./pkg/client -run '^TestBuild$' -count=1go test ./internal/commands ./pkg/client -count=1make verify-formatgolangci-lint run -c golangci.yamlGitHub checks passed on the latest commit (
aa6408f): DCO, CodeQL, build tests on macOS/Linux/Windows, and compatibility acceptance combos.I also tried
go test ./internal/build ./internal/commands ./pkg/client -count=1;internal/commandsandpkg/clientpassed, but the fullinternal/buildpackage failed locally because Docker is not available at/var/run/docker.sock.make lintinitially failed locally because the pinnedgolangci-lintbinary was built with Go 1.24 while this repo targets Go 1.25.10. Reinstalling the same pinned version withGOTOOLCHAIN=go1.25.10and then runninggolangci-lint run -c golangci.yamlpassed with0 issues.