Isolate the Swift collector default-configuration test - #18
Merged
Conversation
Prevent the no-configuration test from reading ambient process or Info.plist values. Hosted macOS agents may provide telemetry variables, so relying on the runner environment makes the assertion depend on CI configuration. This keeps production lookup behavior unchanged and confines test setup to the empty environment it claims to exercise. Amp-Thread-ID: https://ampcode.com/threads/T-01a037c7-e3e7-70e4-b18f-a43cec542d56 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The default collector test claims to exercise an empty configuration, but
EnvironmentValues(values: [:])still reads the process environment and Info.plist. Hosted macOS coverage added in #17 exposed this coupling while validating #12 on agents that provide telemetry exporter variables.What
Disable both fallback readers in that test so it remains deterministic without changing production configuration behavior.
Related: