Skip to content

[Backport] Allow multipart artifact uploads above 5 GiB - #4317

Open
buildkate wants to merge 2 commits into
v3from
backport-4292-multipart-artifacts
Open

[Backport] Allow multipart artifact uploads above 5 GiB#4317
buildkate wants to merge 2 commits into
v3from
backport-4292-multipart-artifacts

Conversation

@buildkate

Copy link
Copy Markdown
Contributor

Description

Backport of #4292 to v3. Buildkite-managed multipart uploads can exceed 5 GiB when the API supplies multipart instructions, while oversized single-form uploads still fail before artifact data is sent.

There are no v3 translation deviations.

Context

See #4292 for the original change and review context.

Testing

  • go test ./internal/artifact
  • go tool gofumpt -extra reports no formatting changes
  • go test ./... was attempted; unrelated tests requiring temporary Git commits fail because this environment has commit signing enabled without an available signing key, and the polyglot hook test requires Ruby.

Disclosures / Credits

Amp performed the backport and validation.

@buildkate
buildkate requested review from a team as code owners September 2, 2026 06:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T06:12:22.415425Z 5f5bb41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@buildkate
buildkate disabled auto-merge September 2, 2026 06:12
@buildkate buildkate added the bug label Sep 2, 2026
ampagent and others added 2 commits September 2, 2026 16:12
Amp-Thread-ID: https://ampcode.com/threads/T-01a0566e-8658-76aa-b219-ab03d078bd30
Co-authored-by: Kate Sy <kate.sy@buildkite.com>
(cherry picked from commit d79427d)
Amp-Thread-ID: https://ampcode.com/threads/T-01a0566e-8658-76aa-b219-ab03d078bd30
Co-authored-by: Kate Sy <kate.sy@buildkite.com>
(cherry picked from commit 7a70657)
@buildkate
buildkate force-pushed the backport-4292-multipart-artifacts branch from 5f5bb41 to e5b931f Compare September 2, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants