Skip mirrors for relative submodule URLs - #4276
Open
davido wants to merge 1 commit into
Open
Conversation
This was referenced Aug 27, 2026
Gerrit: Git mirror checkout fails for relative submodule URLs
bazelbuild/continuous-integration#2815
Open
Submodule URLs from .gitmodules may be relative to the superproject remote. The mirror checkout path currently reads those raw values and runs from the mirror cache directory, where ../java-prettify is treated as a local filesystem path instead of resolving against the superproject remote. Skip only the mirror optimization for relative submodule URLs and let git submodule update resolve them with Git's normal semantics. Absolute submodule URLs still use mirrors. Add regression tests that fail on the current behavior by observing the attempted mirror clone of ../java-prettify, and pass once that relative URL falls back to the normal submodule update path. Closes buildkite#4282. Refs bazelbuild/continuous-integration#2815.
davido
force-pushed
the
issue-2815-minimal-relative-submodule-mirror-fallback
branch
from
August 28, 2026 11:04
43888b3 to
f45afa8
Compare
Contributor
|
Thanks for opening this PR @davido. I’ve created a ticket to track it internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule URLs from .gitmodules may be relative to the superproject remote. The mirror checkout path currently reads those raw values and runs from the mirror cache directory, where ../java-prettify is treated as a local filesystem path instead of resolving against the superproject remote.
Skip only the mirror optimization for relative submodule URLs and let git submodule update resolve them with Git's normal semantics. Absolute submodule URLs still use mirrors.
Add regression tests that fail on the current behavior by observing the attempted mirror clone of ../java-prettify, and pass once that relative URL falls back to the normal submodule update path.
Refs bazelbuild/continuous-integration#2815.
Description
Context
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Affiliation (optional, external contributors)
Disclosures / Credits