Migrate from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3#70
Conversation
|
|
| golang.org/x/text v0.23.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20240826202546-f6391c0de4c7 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
There was a problem hiding this comment.
This remaining indirect one comes from github.com/stretchr/testify. PR at stretchr/testify#1772
There was a problem hiding this comment.
it'd be really wonderful if they merged that PR ...
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
hey @scop, thanks for the PR — any reason to keep this at yaml/v3 instead of upgrading to v4? (It's honestly a little tricky to even tell the difference in the upstream repo given the lack of a CHANGELOG.md or proper releases...)
| golang.org/x/text v0.23.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20240826202546-f6391c0de4c7 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
There was a problem hiding this comment.
it'd be really wonderful if they merged that PR ...
Two reasons: I wanted to keep the change here as small as possible and v4 is still a release candidate (4.0.0-rc4 at time of writing). |
|
Gotcha, for whatever reason I was under the impression that they had released v4 by now, but I see it's still being planned/discussed: yaml/go-yaml#237. I think:
Just going to merge |
stefanvanburen
changed the title
|
@scop looks like there's a test failure; any chance you could look into that? |
gopkg.in/yaml.v3isunmaintained,ref https://github.com/yaml/go-yaml#project-status Upgradeto3.0.4whileatit. 3.0.1...3.0.2diff(3.0.1areidentical): https://gist.github.com/scop/6ec72debf62a9603cff9dc97e6814ddd 3.0.2...3.0.4diff: yaml/go-yaml@v3.0.2...v3.0.4
| } | ||
| // Should be `"\n": "\n"`, but its garbled. | ||
| if string(data) != "? |4+\n: |4+\n" { | ||
| if string(data) != "? |4+\n\n: |4+\n\n" { |
There was a problem hiding this comment.
Looks like this is garbled a bit differently in the new one.
3 participants
gopkg.in/yaml.v3 is unmaintained, ref
https://github.com/yaml/go-yaml#project-status
Upgrade to 3.0.4 while at it.
3.0.1...3.0.2 diff (3.0.1 are identical):
https://gist.github.com/scop/6ec72debf62a9603cff9dc97e6814ddd
3.0.2...3.0.4 diff:
yaml/go-yaml@v3.0.2...v3.0.4