Skip to content

Fix issue with results #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanvanburen merged 2 commits into from
Apr 16, 2026
+2 −2
Merged

Fix issue with results #709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9afc917
Fix issue with results
stefanvanburen Apr 16, 2026
0e7d618
Remove named return
stefanvanburen Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions experimental/incremental/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func (t *Task) aborted() error {
//
// Note: this function really wants to be a method of [Task], but it isn't
// because it's generic.
func Resolve[T any](caller *Task, queries ...Query[T]) (results Results[T], expired error) {
func Resolve[T any](caller *Task, queries ...Query[T]) (Results[T], error) {
caller.checkDone()
if len(queries) == 0 {
return nil, nil
Expand All @@ -225,7 +225,7 @@ func Resolve[T any](caller *Task, queries ...Query[T]) (results Results[T], expi
caller.stopwatch.Stop()
defer caller.stopwatch.Start()

results = make([]Result[T], len(queries))
results := make(Results[T], len(queries))
anyQueries := make([]*AnyQuery, len(queries))
deps := make([]*task, len(queries))

Expand Down
Loading