feat(harness): thinking default-collapsed preference toggle via Leader+t (plan #742) - #751
Closed
btipling wants to merge 1 commit into
Closed
feat(harness): thinking default-collapsed preference toggle via Leader+t (plan #742)#751btipling wants to merge 1 commit into
btipling wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Owner
Author
|
Implementation of plan #742 complete and merge-ready from review (Zig + docs only, no merge).
Next step: |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking default-collapsed preference (Leader +
t) — plan #742A harness preference thinking default = collapsed, ON by default, toggled by a
keyboard shortcut (Leader
Ctrl+Shift+Space, thent), registered on the parentkeymap (#741). When ON, thinking rows stay collapsed even during the active Busy
turn unless the operator expands one; when OFF, today's Busy pin is restored.
Change (Zig + docs only)
thinking_collapse.zig—shouldRenderFullnow takes the preference as anexplicit boolean parameter (
default_collapsed); the module stays pure(imports nothing). Policy: full
iff operator_open OR (NOT default_collapsed AND active_turn_full)— the Busy pin is relaxed when default-collapsed is ON.ui/state.zig—thinking_default_collapsed: bool = true, reset to ON inresetTranscriptScroll().ui/thinking.zig— threads the live preference into the policy; theis_activepin is gated (active rows stay pinned only when the preference isOFF), and active-row clicks route through
thinking_open_l1so the operatorcan expand a row mid-Busy.
keymap.zigaddsAction.thinking_default_toggle+ a leader-pendingtarm inmatch()(likethe
?arm) + aKEY_TABLErow;keymap_dispatch.zigadds thetoggleThinkingDefaulthandler seam +runActionarm (disarms the leader);help_overlay.zigadds therowChordcase (exhaustive switch, compile-forced);ui.zigprovides thetoggleThinkingDefault()seam and wires the dispatch.docs/harness-limits.md(keyboard table + Thinking collapse row)and
docs/agent-stream.md(qualifies the old absolute "Busy keeps thinkingfully expanded" with the preference).
Verification
zig fmt --checkzig build test-richzig build test-rich-invariantszig build harness -Doptimize=Debugbuild-harnessCINo TS files changed → vitest/typecheck/DI-cost gates N/A (per layer rule).
Caps: none added or changed; Cloud ops N/A; no production mutate.
https://github.com/btipling/invincible — parent stack
This is a stacked PR — it must be based on the parent branch
plan/harness-keymap(PR #746, plan #741), per the plan's mandatory guard("never implement against a
mainwithout the keymap"). The parent #746 isstill open/merge-ready, so this PR is opened against
plan/harness-keymaptokeep the diff atomic to #742's delta.
Merge order: land #746 first, then rebase/retarget this PR onto
main(gitautomatically drops the inherited keymap delta) and re-pass adversarial review.
The single git-stack diff vs
plan/harness-keymapis exactly the #742 work.Closes #742