Repository navigation
Ask every tree's lint.yml for the whole-lock audit (closes #1751) - #1762
Merged
Merged
Conversation
tests/check_audit_test.py asked only this repository's workflows for the audit step on the pin reusable-audit.yml names. A tree that writes its lint job out could lack the step or keep an older pin, and no test said so. A per-repository test asks each tree's lint.yml to call reusable-lint.yml@main or to end its lint job with the step, on that pin, the setup-uv step before it sharing its condition. A tree with no uv.lock owes none, uv audit --locked having nothing to read, and a step may carry if: !cancelled(), as bbt's does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/check_audit_test.pyasks every tree with auv.lockfor the whole-lock audit: itslint.ymlcallsreusable-lint.yml@main, or its written-outlintjob ends withuv auditon the pinreusable-audit.ymlnames, after asetup-uvstep with the same condition. Before, only this repository's own workflows were checked, so a tree like bbt could drop the step or keep an older pin with no test saying so.README.mdgrows by two lines, in section 12, where the rule is stated. A shorter wording was found in review; it is left for the next change to that section.Evidence
pre-commit run --all-filesuv run --group test pytest(659 passed, 204 skipped)BTCLIB_INTEGRATION=1 pytest tests/check_audit_test.py, all 14 trees (51 passed, 6 skipped)Ten planted defects in a
lintjob each fail the check, and each comes out XFAIL under the marker a BACKLOG row adds. The branch merges cleanly intoorigin/main. Local review: a dedicated reviewer, then a fresh one, CLEARED 20d1cd1.Closes #1751
🤖 Generated with Claude Code