Skip to content

Draw bitcoin-node-tests requiring btclib (closes #1755) - #1758

Merged
fametrano merged 1 commit into
mainfrom
iss-1755-node-tests-arrow
Oct 16, 2026
Merged

fametrano merged 1 commit into
mainfrom
iss-1755-node-tests-arrow

Conversation

@fametrano

Copy link
Copy Markdown
Member

bitcoin-node-tests asks btclib[bip324]>=2026.10.7, which its arrow to btclib-wallet does not install, so test_the_graph_draws_what_each_pyproject_declares failed on main. This draws the arrow and renders the SVG with the render-dependencies hook.

Evidence

Check on f95ab3f, under the lock Exit
pre-commit run --all-files (the SVG-matches-dot hook included) 0
render-dependencies hook, tree clean after 0
pytest 0
BTCLIB_INTEGRATION=1 pytest 1: four failures, the same on main, tracked by #1740 and #1744

On main the integration run has a fifth failure, the dependency graph's, which this fixes. The new arrow enters no node box. Review: a dedicated and a fresh reviewer CLEARED f95ab3f.

Closes #1755

🤖 Generated with Claude Code

 #1755)

bitcoin-node-tests asks btclib[bip324]>=2026.10.7, which none of the
arrows drawn from it install. Add the arrow and render the SVG with the
render-dependencies hook.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
@fametrano
fametrano merged commit d861fe2 into main Oct 16, 2026
5 of 7 checks passed
@fametrano
fametrano deleted the iss-1755-node-tests-arrow branch October 16, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The dependency graph does not draw bitcoin-node-tests requiring btclib[bip324]

1 participant