Skip to content

A tree with the Best Practices badge has no bypass actor (issue #1740) - #1757

Merged
fametrano merged 1 commit into
mainfrom
iss-1740-no-bypass
Oct 16, 2026
Merged

fametrano merged 1 commit into
mainfrom
iss-1740-no-bypass

Conversation

@fametrano

Copy link
Copy Markdown
Member

In a repository whose README carries the bestpractices.dev badge, main-self-merge now has no bypass actor, so every pull request lands with an approval from somebody other than its author. The maintainer removed the bypass from the seven badge trees today; in an emergency the bypass is added back and removed after the merge. Every other repository keeps the maintainer's pull_request-mode bypass.

tests/settings_test.py now asks for exactly that, reading the badge trees from bestpractices.py's registered(), and README sections 10, 11, 15 and 16, GOVERNANCE.md, CONTRIBUTING.md and ROADMAP.md say so. Without this change the organization check fails on the new settings.

Evidence

Gate on e28397e Exit
uv run --locked --only-group lint pre-commit run --all-files 0
uv run --locked --no-default-groups --group test pytest 0 (659 passed)
BTCLIB_INTEGRATION=1 … pytest 1: only the 4 reds also on main (dependencies_test graph, 3 api-break.yml cells of #1744)
tests/settings_test.py + tests/verbatim_test.py, live settings 0

No rebase: one commit on main 8922010. A fresh local reviewer cleared e28397e after two rounds. Read the settings back:

for r in btclib btclib-wallet btclib-secp256k1 bitcoin-core-rpc btclib-node btclib-ecc btclib-mnemonics; do
  gh api repos/btclib-org/$r/rulesets --jq '.[].id' | xargs -I{} gh api repos/btclib-org/$r/rulesets/{} \
    --jq 'select(.name == "main-self-merge") | "'$r' \(.bypass_actors)"'
done

Part of #1740: the other trees' CONTRIBUTING.md and the bestpractices.dev answers follow.

🤖 Generated with Claude Code

In a repository whose README.md carries the bestpractices.dev badge,
`main-self-merge` has no bypass actor, so every pull request lands with
an approval from somebody other than its author. In an emergency the
maintainer adds the bypass back and removes it after the merge. Any other
repository keeps the maintainer's bypass in `pull_request` mode.

GOVERNANCE.md, CONTRIBUTING.md, ROADMAP.md and README.md (the
Scorecard note, sections 11 and 15, the new-repository step) say so.
settings_test.py asks a badge tree for no bypass actor and any other for
one, reading which tree is which from bestpractices.py's `registered()`.

CONTRIBUTING.md is a shared file the other trees copy; the existing
EXPECTED_DRIFT entry for it already cites this issue, which stays open
until the trees take the text.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
@fametrano
fametrano merged commit 266c288 into main Oct 16, 2026
5 of 7 checks passed
@fametrano
fametrano deleted the iss-1740-no-bypass branch October 16, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant