Repository navigation
A tree with the Best Practices badge has no bypass actor (issue #1740) - #1757
Merged
Merged
Conversation
In a repository whose README.md carries the bestpractices.dev badge, `main-self-merge` has no bypass actor, so every pull request lands with an approval from somebody other than its author. In an emergency the maintainer adds the bypass back and removes it after the merge. Any other repository keeps the maintainer's bypass in `pull_request` mode. GOVERNANCE.md, CONTRIBUTING.md, ROADMAP.md and README.md (the Scorecard note, sections 11 and 15, the new-repository step) say so. settings_test.py asks a badge tree for no bypass actor and any other for one, reading which tree is which from bestpractices.py's `registered()`. CONTRIBUTING.md is a shared file the other trees copy; the existing EXPECTED_DRIFT entry for it already cites this issue, which stays open until the trees take the text. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a repository whose README carries the bestpractices.dev badge,
main-self-mergenow has no bypass actor, so every pull request lands with an approval from somebody other than its author. The maintainer removed the bypass from the seven badge trees today; in an emergency the bypass is added back and removed after the merge. Every other repository keeps the maintainer'spull_request-mode bypass.tests/settings_test.pynow asks for exactly that, reading the badge trees frombestpractices.py'sregistered(), and README sections 10, 11, 15 and 16,GOVERNANCE.md,CONTRIBUTING.mdandROADMAP.mdsay so. Without this change the organization check fails on the new settings.Evidence
uv run --locked --only-group lint pre-commit run --all-filesuv run --locked --no-default-groups --group test pytestBTCLIB_INTEGRATION=1 … pytestmain(dependencies_testgraph, 3api-break.ymlcells of #1744)tests/settings_test.py+tests/verbatim_test.py, live settingsNo rebase: one commit on
main8922010. A fresh local reviewer cleared e28397e after two rounds. Read the settings back:Part of #1740: the other trees'
CONTRIBUTING.mdand the bestpractices.dev answers follow.🤖 Generated with Claude Code