Fail the Actions job if the run of any test set does not complete - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same problem described in brimdata/super#7230 and fixed for SuperDB in brimdata/super#7231 ended up biting us here. Our
go.modstill referenced Go v1.26 and pointed at an older super commit, which made it such that when brimdata/super#7318 merged it forced our runner to start trying to compile SuperDB with Go v1.27 and fail with that originalundefined: decoder.Skipsymptom.The failures in Actions started several days ago here but the job actually kept running "green" due to a problem with the scripts so I only happened to notice the problem because the run was deceptively fast. I've enlisted Claude's help with the changes here that get it to start failing as it should have been as shown in this run on this branch.
In a follow up PR I'll get this repo caught up with the latest super commit so everything runs green and with Go v1.27 again.