Fix --baseurl handling#5
Open
rscottbailey wants to merge 5 commits into
Open
Conversation
If an override URL is specified, and it does not end with a trailing slash, add a trailing slash. The present logic assumes the trailing slash is there, but doesn't mention this anywhere, and you end up with corrupted URLs in the metadata if it's missing the and host and prefix get smushed together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
The code was assuming that baseurl terminated in a "/", resulting in bad things if it doesn't. I recommend checking and adding it (as done here) rather than trusting the user to do the right thing; that's also more consistent with how prefix already is being handled.
Apologies for the extra crud in the commit. (Heavy sigh.) I think I need to just trash and refork my repository before whatever the next thing turns out to be.
Thanks,
Scott