Skip to content

IllegalArgumentException crash with Legendary Tooltips #90

Description

@DilithiumThoride

The issue that #89 is supposed to fix; reporting it to actually log the error and stack trace

Description: Rendering screen

java.lang.IllegalArgumentException: Tooltip text must be components
    at brachy.modularui.utils.TooltipLines.lambda$add$0(TooltipLines.java:138) ~[modularui-mc1.20.1-3.3.1-SNAPSHOT.jar%23183!/:3.3.1-SNAPSHOT] {re:classloading}
    at com.mojang.datafixers.util.Either$Left.ifLeft(Either.java:43) ~[datafixerupper-6.0.8.jar%23107!/:?] {}
    at brachy.modularui.utils.TooltipLines.add(TooltipLines.java:136) ~[modularui-mc1.20.1-3.3.1-SNAPSHOT.jar%23183!/:3.3.1-SNAPSHOT] {re:classloading}
    at brachy.modularui.utils.TooltipLines.add(TooltipLines.java:23) ~[modularui-mc1.20.1-3.3.1-SNAPSHOT.jar%23183!/:3.3.1-SNAPSHOT] {re:classloading}
    at com.anthonyhilyard.legendarytooltips.LegendaryTooltips.onGatherComponentsEvent(LegendaryTooltips.java:176) ~[LegendaryTooltips-1.20.1-forge-1.4.5.jar%23164!/:1.4.5] {re:classloading}

The crash point (TooltipLines.add()) accepts either Components or FormattedText, but if it gets a FormattedText it throws the exception and triggers a client crash. LegendaryTooltips modifies item tooltips and its modified entries contain FormattedText entries.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions