Skip to content

BaseSchemaRenderer issues #65

Description

@PrototypeTrousers

While messing around with MUI in 1.21.1 i noticed 2 issues with BaseSchemaRenderer:

  1. Geometry is translated by the negation of the camera position, effectively doubling the camera distance
    Noticed when i tried to center the view on the center of my block and had to offset the camera by 0.25f instead of 0.5f

  2. compileBlockBuffers in BaseSchemaRenderer$RenderCompileTask only skips RenderShape.INVISIBLE, when it should also skip RenderShape.ENTITYBLOCK_ANIMATED, which are BER-only and do not have a json model, resulting in missing models bein added to the rendering schema.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions