Fix rowSpan header verticalAlignment on repeated tables - #2940
Open
NadeemShadan wants to merge 1 commit into
Open
Fix rowSpan header verticalAlignment on repeated tables#2940NadeemShadan wants to merge 1 commit into
NadeemShadan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2925
Summary
When a repeated table/header contains a row-spanned header cell with
verticalAlignment: 'middle', the rowSpan view-height calculation could compare the cell text position page against row-span ending metadata from the original table layout. On repeated pages this made the computed view height negtive, causing the header text to shift outside the cell.Changes
_lastPageNumber) when comparing the rowSpan start/end pages.headerRows: 2rowSpan: 2verticalAlignment: 'middle'