Skip to content

fix: support application/octet-stream for base64 images in DocMeasure #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nayneshrathod wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

fix: support application/octet-stream for base64 images in DocMeasure #2939

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d1a4d
fix: support application/octet-stream for base64 images in DocMeasure
Jul 13, 2026
b0f9232
Potential fix for pull request finding
nayneshrathod Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DocMeasure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class DocMeasure {
}

convertIfBase64Image(node) {
if (/^data:image\/(jpeg|jpg|png);base64,/.test(node.image)) { // base64 image
if (/^data:(image\/(jpeg|jpg|png)|application\/octet-stream);base64,/.test(node.image)) { // base64 image
Comment thread
nayneshrathod marked this conversation as resolved.
Outdated
let label = `$$pdfmake$$${this.autoImageIndex++}`;
this.pdfDocument.images[label] = node.image;
node.image = label;
Expand Down