Move FilterPanel to shared-components#2796
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2796 +/- ##
==========================================
- Coverage 77.13% 77.11% -0.03%
==========================================
Files 327 326 -1
Lines 23458 23437 -21
Branches 2355 2353 -2
==========================================
- Hits 18095 18074 -21
Misses 5315 5315
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request relocates the FilterPanel UI component into @boxtribute/shared-components and updates frontend consumers to import it from the shared package, improving reuse across Boxtribute frontend apps.
Changes:
- Extend
FilterPanelto support a configurablelabel(default:"Filters") and reflect it in the drawer header andaria-label. - Update
frontviews to importFilterPanelfrom@boxtribute/shared-components/filter/FilterPanel. - Move
react-iconsdependency fromfront/package.jsonto the rootpackage.jsonand updatepnpm-lock.yamlaccordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared-components/filter/FilterPanel.tsx | Adds label prop and updates UI/accessibility attributes for a shared FilterPanel. |
| package.json | Adds react-icons at the workspace root for shared usage. |
| front/package.json | Removes react-icons from the front package after moving usage into shared components/root deps. |
| pnpm-lock.yaml | Reflects dependency move for react-icons from front importer to root importer. |
| front/src/views/Transfers/ShipmentsOverview/ShipmentsOverviewView.tsx | Switches FilterPanel import to shared-components. |
| front/src/views/Products/components/StandardProductsTable.tsx | Switches FilterPanel import to shared-components. |
| front/src/views/Products/components/ProductsTable.tsx | Switches FilterPanel import to shared-components. |
| front/src/views/Boxes/components/BoxesTable.tsx | Switches FilterPanel import to shared-components. |
| front/src/views/Boxes/BoxesView.test.tsx | Updates expected data-testid for the filter drawer button. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
shared-components/filter/FilterPanel.tsx:40
data-testidis currently derived from the user-facinglabel, which makes tests brittle (e.g., copy changes, future i18n) and can produce unexpected IDs for labels with punctuation/whitespace. Prefer keeping a stable test id and (if needed) introduce an explicit prop for customization later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Hd8yfFuD