Skip to content

Move FilterPanel to shared-components#2796

Merged
pylipp merged 1 commit into
masterfrom
filterpanel
Jun 25, 2026
Merged

Move FilterPanel to shared-components#2796
pylipp merged 1 commit into
masterfrom
filterpanel

Conversation

@pylipp

@pylipp pylipp commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (4ddb69e) to head (394faf4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   77.13%   77.11%   -0.03%     
==========================================
  Files         327      326       -1     
  Lines       23458    23437      -21     
  Branches     2355     2353       -2     
==========================================
- Hits        18095    18074      -21     
  Misses       5315     5315              
  Partials       48       48              
Flag Coverage Δ
backend 99.65% <ø> (ø)
frontend 69.95% <ø> (-0.04%) ⬇️
sharedComponents 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request relocates the FilterPanel UI component into @boxtribute/shared-components and updates frontend consumers to import it from the shared package, improving reuse across Boxtribute frontend apps.

Changes:

  • Extend FilterPanel to support a configurable label (default: "Filters") and reflect it in the drawer header and aria-label.
  • Update front views to import FilterPanel from @boxtribute/shared-components/filter/FilterPanel.
  • Move react-icons dependency from front/package.json to the root package.json and update pnpm-lock.yaml accordingly.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared-components/filter/FilterPanel.tsx Adds label prop and updates UI/accessibility attributes for a shared FilterPanel.
package.json Adds react-icons at the workspace root for shared usage.
front/package.json Removes react-icons from the front package after moving usage into shared components/root deps.
pnpm-lock.yaml Reflects dependency move for react-icons from front importer to root importer.
front/src/views/Transfers/ShipmentsOverview/ShipmentsOverviewView.tsx Switches FilterPanel import to shared-components.
front/src/views/Products/components/StandardProductsTable.tsx Switches FilterPanel import to shared-components.
front/src/views/Products/components/ProductsTable.tsx Switches FilterPanel import to shared-components.
front/src/views/Boxes/components/BoxesTable.tsx Switches FilterPanel import to shared-components.
front/src/views/Boxes/BoxesView.test.tsx Updates expected data-testid for the filter drawer button.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

shared-components/filter/FilterPanel.tsx:40

  • data-testid is currently derived from the user-facing label, which makes tests brittle (e.g., copy changes, future i18n) and can produce unexpected IDs for labels with punctuation/whitespace. Prefer keeping a stable test id and (if needed) introduce an explicit prop for customization later.

@pylipp pylipp merged commit 504b344 into master Jun 25, 2026
15 checks passed
@pylipp pylipp deleted the filterpanel branch June 25, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants