Skip to content

Add initial set support #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neved4 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add initial set support #36

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5afe35c
Add filter to `set` flags
Neved4 Nov 16, 2024
c2e4991
Add parsing from `set --` to `set argv`
Neved4 Nov 16, 2024
cc82ec0
Add tests for `set --` and `set -Cefu`
Neved4 Nov 18, 2024
e4e0c46
Add parsing and tests from `set -` to `set argv`
Neved4 Nov 19, 2024
2794cd6
Merge branch 'master' into set
Neved4 Nov 17, 2025
4054ed1
Handle set -- ... "$@" appends
Neved4 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions translate/translate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,33 @@ func (t *Translator) assign(prefix string, a *syntax.Assign) {
}
}

func (t *Translator) parseSetExpr(args []*syntax.Word) bool {
if len(args) < 2 {
return false
}

next, _ := lit(args[1])

if next == "--" {
if len(args) > 2 {
t.str("set argv")
for _, arg := range args[2:] {
t.str(" ")
t.word(arg, false)
}
}
return true
}

for _, arg := range args[1:] {
flag, _ := lit(arg)
if !strings.HasPrefix(flag, "-") {
return false
}
}
return true
}

func (t *Translator) callExpr(c *syntax.CallExpr) {
if len(c.Args) == 0 {
// assignment
Expand All @@ -447,7 +474,12 @@ func (t *Translator) callExpr(c *syntax.CallExpr) {

first := c.Args[0]
l, _ := lit(first)

switch l {
case "set":
if t.parseSetExpr(c.Args) {
return
}
case "shift":
t.str("set -e argv[1]")
case "unset":
Expand Down
4 changes: 4 additions & 0 deletions translate/translate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,8 @@ echo ${cool+a}
echo ${cool:+a}
echo ${cool-a}
echo ${cool:-a}
set -Cefu
Comment thread
Neved4 marked this conversation as resolved.
set -- x y z
unset ASPELL_CONF
for i in a b c ; do
if [ -d "$i/lib/aspell" ]; then
Expand Down Expand Up @@ -392,6 +394,8 @@ echo (set -q cool && echo 'a' || echo)
echo (test -n "$cool" && echo 'a' || echo)
echo (set -q cool && echo "$cool" || echo 'a')
echo (test -n "$cool" && echo "$cool" || echo 'a')

set argv x y z
set -e ASPELL_CONF
for i in a b c
if [ -d "$i"'/lib/aspell' ]
Expand Down