[skip benchmarks]Dissected pipeline#1057
Open
nantonzhang wants to merge 20 commits intomasterfrom
Open
Conversation
Bring the update from master into this branch
| return metric_name.startswith("pose_auc_@") | ||
|
|
||
|
|
||
| def _convert_scalar_auc_metrics_to_percent(metrics: List[GtsfmMetric]) -> List[GtsfmMetric]: |
Collaborator
There was a problem hiding this comment.
just update the AUC code to save it in percent, we dont need this.
| metric_utils.compute_pose_auc_metric( | ||
| rotation_angular_errors, translation_angular_errors, save_dir=output_dirpath | ||
| ) | ||
| pose_auc_metrics = metric_utils.compute_pose_auc_metric( |
Collaborator
There was a problem hiding this comment.
update this method to return percent values?
| ) | ||
|
|
||
|
|
||
| def _convert_scalar_auc_metrics_to_percent(metrics: List[GtsfmMetric]) -> List[GtsfmMetric]: |
Collaborator
There was a problem hiding this comment.
duplicate (but also unnecessary) function
| ) | ||
| parser.add_argument("--ckpt", type=str, default=None, help="Optional checkpoint path.") | ||
| parser.add_argument("--device", type=str, default="cuda", help="Device: cuda or cpu.") | ||
| parser.add_argument("--focal_length", type=float, default=None, help="Optional SIMPLE_PINHOLE focal length.") |
Collaborator
There was a problem hiding this comment.
why is this needed and what does it do?
| parser.add_argument("--device", type=str, default="cuda", help="Device: cuda or cpu.") | ||
| parser.add_argument("--focal_length", type=float, default=None, help="Optional SIMPLE_PINHOLE focal length.") | ||
| parser.add_argument( | ||
| "--pixel_limit", |
Collaborator
There was a problem hiding this comment.
how does this interact with --max_resolution ?
| default="vggt", | ||
| help="Tracker used for BA (vggt or vggsfm).", | ||
| ) | ||
| parser.add_argument("--img_load_resolution", type=int, default=1024, help="Square load resolution for VGGT input.") |
Collaborator
There was a problem hiding this comment.
this should be the same as vggt_fixed_resolution?
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
| export HF_HOME=/nethome/xzhang979/nvme/cache |
Collaborator
There was a problem hiding this comment.
we should not check that in
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
| export HF_HOME=/nethome/xzhang979/nvme/cache |
Collaborator
There was a problem hiding this comment.
also here - remove personal paths?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dissected pipeline for flexibility
run_pipeline.shto run a demo