Change StartupWMClass to com.borgbase.Vorta - #2536
Open
gpenz wants to merge 1 commit into
Open
Conversation
Fixes issue borgbase#2535 Signed-off-by: gpenz <gpenz@noreply.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the StartupWMClass desktop entry from python3 to com.borgbase.Vorta.
Related Issue
#2535
Motivation and Context
Explained in #2535
How Has This Been Tested?
I changed the desktop file locally, logged out and back in, launched Vorta and checked its icon was fine.
Opened a python app that has wmclass=python3 (Universal Radio Hacker) and checked its window wasn't eaten by Vorta.
Repeated a couple times with the change (no bug) and without the change (bug).
Environment: GNOME Wayland, version 50.4, Arch Linux.
It shouldn't affect other areas of the code, however if the wmclass of the application is ever changed (it's affected by QGuiApplication.setDesktopFileName()) it should be updated here too.
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.