Story 2406: Update Search Bar with No-JS design#2433
Open
julhoang wants to merge 3 commits into
Open
Conversation
7b4d8e4 to
283d7f0
Compare
julioest
approved these changes
May 18, 2026
herzog0
approved these changes
May 19, 2026
Collaborator
herzog0
left a comment
There was a problem hiding this comment.
Behavior is fine. I just think that from a UI/UX perspective, if the field is disabled we should make that more clear with the standard disabled colors we have in the Figma foundational specs, and remove the cursor pointer.
I'm approving though, as there're no designs for that!
Collaborator
|
Works without issues. I agree with @herzog0 that design could be improved maybe removing the hover state. Approving. |
ycanales
approved these changes
May 19, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2406
Summary & Context
This ticket doesn't require any BE changes as the search component is already connected to Algolia and correctly run queries across two indexes:
LibrariesandLearn. The actual content crawling, indexing and search logic is handled by this Boost Gecko repo: https://github.com/cppalliance/boost-gecko. This PR handles small UI updates to the No-JavaScript state.Changes
None
Screenshots
Self-review Checklist
Frontend