Story: Add support for boostlook v3 and vendor the file#2411
Open
jlchilders11 wants to merge 2 commits into
Open
Story: Add support for boostlook v3 and vendor the file#2411jlchilders11 wants to merge 2 commits into
jlchilders11 wants to merge 2 commits into
Conversation
Refreshes the vendored stylesheet to pull in the latest boostlook v3 build. Color tokens are reorganized (neutral becomes primary, blue becomes secondary), and a few new palettes show up alongside the new Metalab 2.0 heading and spacing primitives. Also includes the library README pass: proper h1 sizing on mobile and desktop, a dark-mode background, horizontally scrollable tables on small screens, and tighter literal-block indentation.
julioest
approved these changes
May 12, 2026
julhoang
approved these changes
May 14, 2026
Collaborator
julhoang
left a comment
julhoang
left a comment
There was a problem hiding this comment.
Looks good to me!
--
Just one thought from looking at base.html: I understand loading boostlook-v3.css here follows the existing pattern, but at some point it might be worth scoping it to just the /doc template(s) where the boostlook styles are actually used. That would prevent unintentional style leakage and avoid exposing CSS variables and classes we don't want available on V3 pages.
Collaborator
|
Also, would you mind rebasing on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: #2399
Summary & Context
Implements
boostlook-v3.cssin the site, hidden behind a feature flag.Changes
Since we are vendoring this file, if any changes are made upstream we will need to make sure to downstream any changes made. Additionally, this file and flag should be removed during full prod deployment for cleanliness.
Self-review Checklist