Fix circle layout docs and cleanup#469
Merged
jeremy-murphy merged 6 commits intoMay 30, 2026
Merged
Conversation
Contributor
Author
|
any feedback on this tiny fix @jeremy-murphy |
Becheler
reviewed
May 21, 2026
Becheler
requested changes
May 21, 2026
Collaborator
There was a problem hiding this comment.
I approved after the regression was fixed, I think it can be safely merged.
Let's wait for @jeremy-murphy 😄
Plan to merge in order: #469 → #489 → #491
Becheler
added
the
priority: high
Becheler
approved these changes
May 23, 2026
This was referenced May 23, 2026
Open
Becheler
added
priority: medium
jeremy-murphy
approved these changes
May 26, 2026
Collaborator
|
Sorry, thought I merged this already but I guess I only hit approve. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix synopsis in the circle_layout docs (currently broken)
Incidentally I looked at the source code of that function and decided to do some small tweaking of the source code to add a const, use auto and remove a typedef.