Skip to content

fix GetPackageManager("") causing panic due to no pm autoselected #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluet merged 2 commits into from
May 30, 2025
Merged

fix GetPackageManager("") causing panic due to no pm autoselected #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1298c05
fix GetPackageManager("") causing panic due to no pm autoselected
May 23, 2025
22a3705
fix syspkg.GetPackageManager never returning errors despite the docum…
aijanai May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type SysPkg interface {
// If the name is empty, the first available package manager will be returned.
// If no suitable package manager is found, an error is returned.
// Note: only package managers that are specified in the IncludeOptions when creating the SysPkg instance (with New() method) will be returned. If you want to use package managers that are not specified in the IncludeOptions, you should use the FindPackageManagers() method to get a list of all available package managers, or use RefreshPackageManagers() with the IncludeOptions parameter to refresh the package manager list.
GetPackageManager(name string) PackageManager
GetPackageManager(name string) (PackageManager, error)

// Install(pkgs []string, opts *manager.Options) ([]manager.PackageInfo, error)
// Delete(pkgs []string, opts *manager.Options) ([]manager.PackageInfo, error)
Expand Down
29 changes: 26 additions & 3 deletions syspkg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@
// if err != nil {
// log.Fatal(err)
// }
// aptManager := sysPkg.GetPackageManager("apt")
// aptManager,err := sysPkg.GetPackageManager("apt")
package syspkg

import (
"errors"
"log"
"sort"

"github.com/bluet/syspkg/manager"
"github.com/bluet/syspkg/manager/apt"
Expand Down Expand Up @@ -97,8 +98,30 @@ func (s *sysPkgImpl) FindPackageManagers(include IncludeOptions) (map[string]Pac
}

// GetPackageManager returns a PackageManager instance by its name (e.g., "apt", "snap", "flatpak", etc.).
func (s *sysPkgImpl) GetPackageManager(name string) PackageManager {
return s.pms[name]
// if name is empty, return the first available
func (s *sysPkgImpl) GetPackageManager(name string) (PackageManager,error) {
var pm PackageManager

// if there are no package managers, return before accessing non existing properties
if len(s.pms) == 0 {
return nil, errors.New("no supported package manager detected")
}

if name == "" {
// get first pm available, lexicographically sorted
keys := make([]string, 0, len(s.pms))
for k := range s.pms {
keys = append(keys, k)
}
sort.Strings(keys)
pm = s.pms[keys[0]]
} else {
pm,found := s.pms[name]
if !found {
return pm, errors.New("no such package manager")
}
}
return pm, nil
}

// RefreshPackageManagers refreshes the internal list of available package managers, and returns the new list.
Expand Down
65 changes: 44 additions & 21 deletions syspkg_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestNewPackageManager(t *testing.T) {
AllAvailable: true,
})
if err != nil {
t.Fatalf("GetPackageManagers() error: %+v", err)
t.Fatalf("FindPackageManagers() error: %+v", err)
}

log.Printf("pms: %+v", pms)
Expand All @@ -53,73 +53,96 @@ func TestNewPackageManager(t *testing.T) {
// if we are on any other distro, we should have nothing

if OSInfo.Distribution == "ubuntu" || OSInfo.Distribution == "debian" || OSInfo.Distribution == "mint" || OSInfo.Distribution == "PopOS" || OSInfo.Distribution == "elementary" || OSInfo.Distribution == "Zorin" || OSInfo.Distribution == "ChromeOS" {
if _, ok := pms["apt"]; !ok && s.GetPackageManager("apt") == nil {
if _, ok := pms["snap"]; !ok && s.GetPackageManager("snap") == nil {
if _, ok := pms["flatpak"]; !ok && s.GetPackageManager("flatpak") == nil {
pm,err:=s.GetPackageManager("apt")

if err != nil && pm == nil {
pm,err:=s.GetPackageManager("snap")

if err!=nil && pm == nil {
pm,err:=s.GetPackageManager("flatpak")

if err!=nil && pm == nil {
t.Fatalf("apt, snap, or flatpak package manager not found")
}
}
}
} else if OSInfo.Distribution == "fedora" || OSInfo.Distribution == "centos" || OSInfo.Distribution == "rhel" || OSInfo.Distribution == "rockylinux" || OSInfo.Distribution == "almalinux" || OSInfo.Distribution == "amazon linux" || OSInfo.Distribution == "oracle linux" || OSInfo.Distribution == "scientific linux" || OSInfo.Distribution == "cloudlinux" {
if _, ok := pms["dnf"]; !ok && s.GetPackageManager("dnf") == nil {
if _, ok := pms["yum"]; !ok && s.GetPackageManager("yum") == nil {
pm,err:=s.GetPackageManager("dnf")
if err != nil && pm == nil {
pm,err:=s.GetPackageManager("yum")
if err != nil && pm == nil {
t.Fatalf("dnf or yum package manager not found")
}
}
} else if OSInfo.Distribution == "opensuse" {
if _, ok := pms["zypper"]; !ok && s.GetPackageManager("zypper") == nil {
pm,err:=s.GetPackageManager("zypper")
if err != nil && pm == nil {
t.Fatalf("zypper package manager not found")
}
} else if OSInfo.Distribution == "alpine" {
if _, ok := pms["apk"]; !ok && s.GetPackageManager("apk") == nil {
pm,err:=s.GetPackageManager("apk")
if err != nil && pm == nil {
t.Fatalf("apk package manager not found")
}
} else if OSInfo.Distribution == "arch" {
if _, ok := pms["pacman"]; !ok && s.GetPackageManager("pacman") == nil {
pm,err:=s.GetPackageManager("pacman")
if err != nil && pm == nil {
t.Fatalf("pacman package manager not found")
}
} else if OSInfo.Distribution == "gentoo" {
if _, ok := pms["emerge"]; !ok && s.GetPackageManager("emerge") == nil {
pm,err:=s.GetPackageManager("emerge")
if err != nil && pm == nil {
t.Fatalf("emerge package manager not found")
}
} else if OSInfo.Distribution == "slackware" {
if _, ok := pms["slackpkg"]; !ok && s.GetPackageManager("slackpkg") == nil {
pm,err:=s.GetPackageManager("slackpkg")
if err != nil && pm == nil {
t.Fatalf("slackpkg package manager not found")
}
} else if OSInfo.Distribution == "void" {
if _, ok := pms["xbps"]; !ok && s.GetPackageManager("xbps") == nil {
pm,err:=s.GetPackageManager("xbps")
if err != nil && pm == nil {
t.Fatalf("xbps package manager not found")
}
} else if OSInfo.Distribution == "solus" {
if _, ok := pms["eopkg"]; !ok && s.GetPackageManager("eopkg") == nil {
pm,err:=s.GetPackageManager("eopkg")
if err != nil && pm == nil {
t.Fatalf("eopkg package manager not found")
}
} else if OSInfo.Distribution == "freebsd" || OSInfo.Distribution == "dragonfly" || OSInfo.Distribution == "termux" {
if _, ok := pms["pkg"]; !ok && s.GetPackageManager("pkg") == nil {
pm,err:=s.GetPackageManager("pkg")
if err != nil && pm == nil {
t.Fatalf("pkg package manager not found")
}
} else if OSInfo.Distribution == "openbsd" || OSInfo.Distribution == "netbsd" {
if _, ok := pms["pkg_add"]; !ok && s.GetPackageManager("pkg_add") == nil {
pm,err:=s.GetPackageManager("pkg_add")
if err != nil && pm == nil {
t.Fatalf("pkg_add package manager not found")
}
} else if OSInfo.Distribution == "macos" {
if _, ok := pms["brew"]; !ok && s.GetPackageManager("brew") == nil {
pm,err:=s.GetPackageManager("brew")
if err != nil && pm == nil {
t.Fatalf("brew package manager not found")
}
} else if OSInfo.Distribution == "windows" {
if _, ok := pms["chocolatey"]; !ok && s.GetPackageManager("chocolatey") == nil {
if _, ok := pms["scoop"]; !ok && s.GetPackageManager("scoop") == nil {
if _, ok := pms["winget"]; !ok && s.GetPackageManager("winget") == nil {
pm,err:=s.GetPackageManager("chocolatey")
if err != nil && pm == nil {
pm,err:=s.GetPackageManager("scoop")
if err != nil && pm == nil {
pm,err:=s.GetPackageManager("winget")
if err != nil && pm == nil {
t.Fatalf("chocolatey, scoop, or winget package manager not found")
}
}
}
} else if OSInfo.Distribution == "android" {
if _, ok := pms["f-droid"]; !ok && s.GetPackageManager("f-droid") == nil {
pm,err:=s.GetPackageManager("f-droid")
if err != nil && pm == nil {
t.Fatalf("f-droid package manager not found")
}
} else if OSInfo.Distribution == "ios" {
if _, ok := pms["cydia"]; !ok && s.GetPackageManager("cydia") == nil {
pm,err:=s.GetPackageManager("cydia")
if err != nil && pm == nil {
t.Fatalf("cydia package manager not found")
}
} else {
Expand Down