fix(governance): return CC voters as CIP-129 cc_hot ids in proposal votes - #467
Merged
Conversation
…otes For "voter_role": "constitutional_committee" the voter field carried the raw 28-byte hash in hex, with no way to tell a key hash from a script hash. DRep voters in the same response are already CIP-129 bech32 and SPO voters are pool bech32, so committee voters were the only role left ambiguous. Document the voter field as a Bech32 identifier for every role and switch the committee example to a CIP-129 hot credential (cc_hot1...), whose header byte encodes the key/script distinction — matching the representation already used by the /governance/committee endpoints. Fixes #465
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For
"voter_role": "constitutional_committee", thevoterfield of/governance/proposals/{tx_hash}/{cert_index}/votescarried the raw 28-byte hot credential hash in hex, with no way to tell a key hash from a script hash. DRep voters in the same response are already CIP-129 bech32 and SPO voters are pool bech32, so committee voters were the only ambiguous role.This documents the
voterfield as a Bech32 identifier for every role and switches the committee example to a CIP-129 hot credential (cc_hot1...), whose header byte encodes the key/script distinction — matching the representation the/governance/committeeendpoints already use.Backend counterpart: blockfrost/blockfrost-backend-ryo#351 (the actual conversion; verified byte-for-byte against Koios
voter_idfor mainnet CC votes).Note: this changes the value format of
voterfor constitutional committee entries only (raw hex →cc_hot1...).Fixes #465