Exercise returnable: false widgets and preserve highlighting#1123
Draft
jwils wants to merge 4 commits intojoshauw/fetchable-false-prototypefrom
Draft
Exercise returnable: false widgets and preserve highlighting#1123jwils wants to merge 4 commits intojoshauw/fetchable-false-prototypefrom
returnable: false widgets and preserve highlighting#1123jwils wants to merge 4 commits intojoshauw/fetchable-false-prototypefrom
Conversation
81e87d8 to
c006569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
returnable: falseon both a leaf field and an object fieldreturnable: falsefields by only excluding non-highlightable hidden fields from_source_source.excludesbehaviorTesting
bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/datastore_config/index_mappings/miscellaneous_spec.rbNO_VCR=1 bundle exec rspec elasticgraph-graphql/spec/acceptance/returnable_fields_spec.rbscript/lint elasticgraph-schema_definition/lib/elastic_graph/schema_definition/mixins/has_indices.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/datastore_config/index_mappings/miscellaneous_spec.rb elasticgraph-graphql/spec/acceptance/returnable_fields_spec.rbThis supersedes merged PR #1120 after reversing the stack order.