Open
Conversation
7411c18 to
dc21bab
Compare
dc21bab to
233c97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #1079 mixed extraction, new config surface area, and test movement into one large change. This first step isolates the JSON-ingestion extraction while preserving the existing schema_definition behavior and test surface as much as possible.
What
elasticgraph-json_ingestiongem with the extracted JSON schema ingestion implementation and testselasticgraph-schema_definitionauto-wired for JSON ingestion and preserve old require paths via compatibility wrappersRisk Assessment
Medium. This moves schema-definition internals and artifact generation code, but preserves the existing public behavior and is covered by the extracted gem specs plus the preserved schema_definition unit and integration suites.
References
Generated with Codex