Skip to content

Extract S3 body loading from indexer lambda processor#1083

Open
jwils wants to merge 1 commit intojoshuaw/indexer-runtime-event-decoderfrom
joshuaw/indexer-runtime-message-body-loader
Open

Extract S3 body loading from indexer lambda processor#1083
jwils wants to merge 1 commit intojoshuaw/indexer-runtime-event-decoderfrom
joshuaw/indexer-runtime-message-body-loader

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented Mar 23, 2026 •
edited
Loading

Summary

  • extract SQS message body resolution into a dedicated SqsMessageBodyLoader
  • keep SqsProcessor focused on orchestration and metadata merging, and remove its vestigial s3_client: pass-through
  • move S3 offloading coverage to loader-focused specs and keep the process RBS return type aligned with the actual batch-failure response

Why

@jwils jwils force-pushed the joshuaw/indexer-runtime-message-body-loader branch from a4cbc2c to c7423c4 Compare March 23, 2026 03:48
@jwils jwils force-pushed the joshuaw/indexer-runtime-event-decoder branch from 327b53f to cd70e31 Compare March 23, 2026 04:10
@jwils jwils force-pushed the joshuaw/indexer-runtime-message-body-loader branch from c7423c4 to 759b9de Compare March 23, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayousufi ayousufi Awaiting requested review from ayousufi ayousufi is a code owner

@BrianSigafoos-SQ BrianSigafoos-SQ Awaiting requested review from BrianSigafoos-SQ BrianSigafoos-SQ is a code owner

@bsorbo bsorbo Awaiting requested review from bsorbo bsorbo is a code owner

@jwondrusch jwondrusch Awaiting requested review from jwondrusch jwondrusch is a code owner

@myronmarston myronmarston Awaiting requested review from myronmarston myronmarston is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jwils