Skip to content

C1: Demote sensitive data logs from Information to Debug#910

Merged
dangershony merged 1 commit into
mainfrom
security/c1-demote-sensitive-logs
Jul 4, 2026
Merged

C1: Demote sensitive data logs from Information to Debug#910
dangershony merged 1 commit into
mainfrom
security/c1-demote-sensitive-logs

Conversation

@DavidGershony

Copy link
Copy Markdown
Collaborator

Summary

Demote all sensitive data logs from LogInformation to LogDebug to prevent cryptographic material from appearing in production log output.

Changes

  • FounderTransactionActions: Remove private key hex, transaction hex, and WitScript content from log messages (4 lines)
  • InvestorTransactionActions: Remove investor public key and founder recovery key from log messages (2 lines)
  • SeederTransactionActions: Remove seeder public key from log message (1 line)
  • DerivationOperations: Remove full key material and intermediate hash values; keep only non-sensitive identifiers (3 lines)

What was exposed before

File Leaked data
FounderTransactionActions founder-recovery-pubkey, unsigned tx hex, WitScript hex, signed tx hex
InvestorTransactionActions investor-pubkey, founder-recovery-pubkey
SeederTransactionActions seeder-pubkey
DerivationOperations angorRootKey, full pubkey, WitHash

Testing

All 154 shared tests pass.

Prevent sensitive data (private keys, public keys, transaction hex,
WitScript content, recovery keys) from appearing in production logs.

All LogInformation calls that included cryptographic material or
transaction data are demoted to LogDebug with structured message
templates that exclude sensitive values.

Files: FounderTransactionActions, InvestorTransactionActions,
SeederTransactionActions, DerivationOperations
@dangershony dangershony merged commit 8132c98 into main Jul 4, 2026
3 checks passed
@dangershony dangershony deleted the security/c1-demote-sensitive-logs branch July 4, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants