Skip to content

Preserve sandbox storageMb during apply#337

Open
mstolarzblaxelai wants to merge 1 commit into
mainfrom
mstolarz/eng-3024-sandbox-storage-mb
Open

Preserve sandbox storageMb during apply#337
mstolarzblaxelai wants to merge 1 commit into
mainfrom
mstolarz/eng-3024-sandbox-storage-mb

Conversation

@mstolarzblaxelai

@mstolarzblaxelai mstolarzblaxelai commented Jun 25, 2026

Copy link
Copy Markdown
  • Preserves storageMb when applying sandbox runtime config before typed SDK support lands.
  • Adds storageMb to generated sandbox config samples.
  • Covers runtime field preservation and sample rendering.

Note

Adds storageMb to the list of extra runtime fields preserved during sandbox apply, adds a commented-out example in the TOML sample config, a new YAML sample file, and test coverage for both.

Written by Mendral for commit e276c9d.

@mendral-app mendral-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The change is minimal and correct: it appends "storageMb" to the allowlist in preserveExtraRuntimeFields, which uses a safe map-lookup pattern. The test confirms the field round-trips through the preservation logic. No security, correctness, or data-loss concerns in this diff.

Tag @mendral-app with feedback or questions. View session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants