OTWO-7681 Improvement functionlity of openhub for new UI/UX#1917
Open
bd-vaibhav wants to merge 2 commits into
Open
OTWO-7681 Improvement functionlity of openhub for new UI/UX#1917bd-vaibhav wants to merge 2 commits into
bd-vaibhav wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Open Hub’s UI/UX by introducing a global “page loader” overlay for slow navigations, refining search results pagination placement/styling, and adjusting password reset/account settings UX for better security and correctness.
Changes:
- Added a global page loader partial + styling + JS behavior to display a spinner overlay when navigating to selected “slow” pages.
- Moved and restyled search pagination info so it appears between the filter bar and results.
- Improved password reset messaging (anti-enumeration) and gated the “change password” settings card to only appear for the signed-in user.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config/locales/en.yml | Adds i18n string for loader and updates password reset success copy. |
| app/views/shared/_search_dingus.html.haml | Repositions pagination info render relative to the filter bar/results. |
| app/views/shared/_page_loader.html.haml | Adds the page loader overlay markup (spinner + loading text). |
| app/views/passwords/create.html.haml | Updates success-state heading copy. |
| app/views/layouts/application.html.haml | Renders the page loader globally on all pages. |
| app/views/accounts/settings.html.haml | Shows “Change password” only when viewing your own account settings. |
| app/assets/stylesheets/search-dingus.sass | Moves pagination info styling to a global rule and adjusts presentation. |
| app/assets/stylesheets/page_loader.sass | Introduces overlay/spinner styling for the global loader. |
| app/assets/javascripts/page_loader.js | Adds click-based detection to show/hide the loader around slow navigations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.