OTWO 7677 Fix enlistments and Highcharts related bugs in New UI/UX#1910
Open
bd-vaibhav wants to merge 3 commits into
Open
OTWO 7677 Fix enlistments and Highcharts related bugs in New UI/UX#1910bd-vaibhav wants to merge 3 commits into
bd-vaibhav wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets enlistment form submission issues and multiple Highcharts/UI watermark behaviors as part of the New UI/UX updates.
Changes:
- Removes/adjusts Highcharts watermark handling across JS and SASS (including dark theme behavior).
- Tweaks enlistment form submission selector to match updated markup/classes.
- Updates chart initialization defaults (exporting/credits disabled globally).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/decorators/analysis/code_history_chart.rb | Adjusts chart option composition for code history charts (currently introduces a Ruby syntax error). |
| app/assets/stylesheets/streamgraph.sass | Removes streamgraph watermark background styling. |
| app/assets/stylesheets/dark_theme.sass | Removes dark-mode watermark overlay/pseudo-element logic for Highcharts containers. |
| app/assets/stylesheets/charts.sass | Removes watermark background rules for multiple chart containers. |
| app/assets/stylesheets/api/custom.sass | Refactors CVSS chart styling; currently makes dark-theme text overrides apply in light theme too. |
| app/assets/javascripts/theme_toggle.js | Removes chart watermark refresh hook on theme toggle. |
| app/assets/javascripts/enlistments.js.coffee | Updates selector used to submit the enlistment form. |
| app/assets/javascripts/charts.js | Removes dark watermark swapping logic; disables exporting/credits via Highcharts.setOptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Niharika1117
changed the title
Niharika1117
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.