Skip to content

tests: add test vectors - #1378

Open
quexten wants to merge 2 commits into
mainfrom
test-vectors-add
Open

tests: add test vectors#1378
quexten wants to merge 2 commits into
mainfrom
test-vectors-add

Conversation

@quexten

@quexten quexten commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Adds structured test vectors for different account versions. We will add loading functionality later. The aim here is to have all actions (pin, unlock, key rotation) tested for all version types, to prevent regressions such as "a cipher key cipher breaks upon key rotation" which we've recently had.

Ticket: https://bitwarden.atlassian.net/browse/PM-41875

There will be follow-up PR's adding support for these in the integration tests. We can also add rust facilities to make using these in unit tests easier.

@quexten
quexten marked this pull request as ready for review August 12, 2026 08:15
@quexten
quexten requested a review from a team as a code owner August 12, 2026 08:15
@quexten
quexten requested a review from coroiu August 12, 2026 08:15
@github-actions

Copy link
Copy Markdown
Contributor

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@quexten
quexten requested review from a team and mandreko-bitwarden August 12, 2026 08:18
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: test-vectors-add (fb6361d)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
typescript ✅ No breaking changes detected Compilation passed with new SDK version - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.28%. Comparing base (a91e406) to head (ff40030).
⚠️ Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
+ Coverage   85.81%   86.28%   +0.46%     
==========================================
  Files         490      500      +10     
  Lines       70590    73444    +2854     
==========================================
+ Hits        60574    63368    +2794     
- Misses      10016    10076      +60     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant