[PM-39979] Item-type Send backend integration work - #1377
Closed
mcamirault wants to merge 1 commit into
Closed
Conversation
harr1424
approved these changes
Aug 14, 2026
| None, | ||
| None, | ||
| Some(Box::new(bitwarden_api_api::models::SendDataModel { | ||
| encryption_version: Some(SendEncryptionType::V1.into()), |
Contributor
There was a problem hiding this comment.
🎨 It might be nice to define the encryption type being used as a const at the top of the file. This would make it simpler to change down the road.
| r#type: input.r#type, | ||
| file: input.file, | ||
| text: input.text, | ||
| // TODO - Use the `data` field when implementing item-type Send support |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if creating these item-type Sends via the CLI is a desired feature, but if it is I think it'll be a follow-on to the current work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39979
📔 Objective
This PR adds support for creating and editing Item-type Sends in the SDK, which will be used for the integration work starting with this clients PR
🚨 Breaking Changes