Skip to content

remove sm code from bitwarden-core - #1355

Draft
addisonbeck wants to merge 1 commit into
mainfrom
ps/PM-25937-remove-sm-from-core
Draft

remove sm code from bitwarden-core#1355
addisonbeck wants to merge 1 commit into
mainfrom
ps/PM-25937-remove-sm-from-core

Conversation

@addisonbeck

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

🚨 Breaking Changes

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: ps/PM-25937-remove-sm-from-core (e326e6c)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
typescript ✅ No breaking changes detected Compilation passed with new SDK version - View Details
android ❌ Breaking changes detected Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes must be ready for merge in bitwarden/android. - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.62720% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.14%. Comparing base (0c2bbc2) to head (f2b001b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...den_license/bitwarden-sm/src/login_access_token.rs 56.55% 53 Missing ⚠️
crates/bitwarden-auth/src/login/access_token.rs 0.00% 8 Missing ⚠️
crates/bitwarden-auth/src/api/response/mod.rs 91.66% 2 Missing ⚠️
crates/bitwarden-auth/src/token_management/mod.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   85.95%   86.14%   +0.19%     
==========================================
  Files         495      504       +9     
  Lines       71424    72832    +1408     
==========================================
+ Hits        61390    62741    +1351     
- Misses      10034    10091      +57     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Remove SM code from bitwarden-core crate, and move it to either
bitwarden-auth or bitwarden-sm.

You can find the SM code in core by searching for #[cfg(feature = “secrets”)]
At the end of this work the "secrets" feature should not exist.

Latest status before this change:

> Todd Martin
> February 6, 2026 at 3:55 PM
> @dani Garcia is this done already with your work in PM-25283?

> Dani Garcia
> February 9, 2026 at 5:41 AM
> @todd Martin I think core still has the SM code for access token caching
> there, which we’ll have to move somewhere else

When doing a code review we should ask ourselves: did we do anything other
than move access token caching logic?

https://bitwarden.atlassian.net/browse/PM-25937
@addisonbeck
addisonbeck force-pushed the ps/PM-25937-remove-sm-from-core branch from f2b001b to ac44379 Compare August 6, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant