Skip to content

llm: Ignore acknowledgements drift in the SDK-update-evaluate job - #2984

Merged
SaintPatrck merged 1 commit into
mainfrom
llm/sdk-update-evaluate-reset-baseline-drift
Aug 21, 2026
Merged

llm: Ignore acknowledgements drift in the SDK-update-evaluate job#2984
SaintPatrck merged 1 commit into
mainfrom
llm/sdk-update-evaluate-reset-baseline-drift

Conversation

@SaintPatrck

@SaintPatrck SaintPatrck commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

AI-78

📔 Objective

The SDK-update-evaluate workflow was failing on drift it introduces itself. Every Debug build, including the workflow's baseline build and the agent's own verify build, regenerates Settings.bundle acknowledgements via LicensePlist, unrelated to the SDK bump being evaluated, and that dirtied tracked files enough to trip the push step's uncommitted-changes guard regardless of whether the agent's fix was clean. Marks those paths skip-worktree right after checkout so the rest of the job never sees the drift.

Every Debug build regenerates Settings.bundle acknowledgements via
LicensePlist, unrelated to the SDK bump the workflow evaluates. That dirtied
tracked files before the push step's uncommitted-changes guard ran, failing
the job regardless of whether the agent's fix was clean.

Mark those paths skip-worktree right after checkout, so git ignores changes
to them for the rest of the job no matter how many Debug builds run.
@SaintPatrck SaintPatrck added the ai-review Request a Claude code review label Aug 20, 2026
@github-actions github-actions Bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Aug 20, 2026
@SaintPatrck
SaintPatrck marked this pull request as ready for review August 20, 2026 20:03
@SaintPatrck
SaintPatrck requested a review from a team as a code owner August 20, 2026 20:03
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single step to .github/workflows/sdlc-sdk-update-evaluate.yml that marks the generated Settings.bundle/Acknowledgements* files skip-worktree immediately after checkout, so LicensePlist regeneration during Debug builds no longer trips the Push any resolved fix uncommitted-changes guard. I verified both .license-plist-pm.yml and .license-plist-bwa.yml output paths are covered by the two globs, and that both configs exclude: owner: bitwarden — so an sdk-swift revision bump can never legitimately alter these files, making the masking safe rather than a way to silently drop a real fix. I also confirmed the flag does not affect the step's other guards, which compare origin/$_BRANCH_NAME to HEAD tree-to-tree, and that the agent has no git update-index grant to undo it. Scope is narrow, the rationale is documented inline, and the step is correctly gated on steps.gate.outputs.skip == 'false' like its neighbors.

Code Review Details

No findings.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.50%. Comparing base (f4b4283) to head (533ce1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   79.50%   79.50%   -0.01%     
==========================================
  Files        1169     1169              
  Lines       75028    75028              
==========================================
- Hits        59650    59649       -1     
- Misses      15378    15379       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck
SaintPatrck enabled auto-merge (squash) August 21, 2026 15:51
@SaintPatrck
SaintPatrck merged commit 6af112c into main Aug 21, 2026
20 of 27 checks passed
@SaintPatrck
SaintPatrck deleted the llm/sdk-update-evaluate-reset-baseline-drift branch August 21, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants