[PM-38792] feat: Enforce Send deletion date via Send Controls policy

[matt-livefront]

🎟️ Tracking

PM-38792

📔 Objective

Adds enforcement of the new Send Controls policy deletionHours option. When an organization restricts the Send deletion date, a non-owner/non-admin user sees the enforced deletion date pre-selected and locked on the Send add/edit screen, with helper text explaining the restriction. Also adds the previously-missing 14 days deletion option to the menu.

📸 Screenshots

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the Send Controls deletionHours enforcement across SendPolicyOptions (minimum-hours resolution across applying policies), the new SendDeletionDateType.fourteenDays case and from(hours:) mapping, and the add/edit Send screen (state, processor, view). The implementation mirrors the existing enforcedAccessType pattern, and the feature flag gate lives in PolicyService.getSendPolicyOptions() so enforcedDeletionDateHours is only populated when sendControls is enabled. Test coverage is thorough: preset mapping, custom fallback, multi-policy resolution, processor load behavior, and the disabled/helper-text view states.

Code Review Details

No blocking findings.

• ♻️ : Pre-existing (not introduced here, noted for awareness) — removePassword replaces the whole state with AddEditSendItemState(sendView:), which resets sendPolicyOptions and isSendControlsPolicyEnabled to defaults. After removing a password in edit mode the newly added deletion-date enforcement (and the access-type enforcement from the base branch) silently drops until the screen reloads. Carrying the policy fields onto newState alongside isOptionsExpanded would preserve them.
  • BitwardenShared/UI/Tools/Send/SendItem/AddEditSendItem/AddEditSendItemProcessor.swift:291

Notes considered and cleared during review:

• In edit mode loadData overwrites the loaded Send's deletion date with the policy-enforced date, which can shift an existing Send's expiry when only the name is edited. This is consistent with how enforcedAccessType is applied and keeps the saved value within the policy limit.
• A non-preset enforced value yields a .custom date that is absent from availableDeletionDateTypes in .add mode; BitwardenMenuField renders selection.localizedName directly and the field is disabled, so it displays correctly.
• AnyCodable.intValue handles int/double/string server encodings for deletionHours.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.59%. Comparing base (5f54987) to head (e6e82db).

Additional details and impacted files

@@                                Coverage Diff                                 @@
##           matt/PM-40460-send-controls-restrict-send-type    #2910      +/-   ##
==================================================================================
- Coverage                                           81.66%   79.59%   -2.08%     
==================================================================================
  Files                                                1049     1170     +121     
  Lines                                               67675    75327    +7652     
==================================================================================
+ Hits                                                55264    59953    +4689     
- Misses                                              12411    15374    +2963     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fedemkr]

Looks good, just a ⛏️

[fedemkr]

⛏️ Can't we use the key made from the value? ThisDateIsEnforcedByYourOrganization