[PM-40460] feat: Enforce Send type restriction via Send Controls policy - #2909
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Re-reviewed after Code Review DetailsNo findings. Notes considered and intentionally not raised as findings:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## matt/PM-40248-send-controls-access-controls #2909 +/- ##
===============================================================================
+ Coverage 79.37% 79.58% +0.21%
===============================================================================
Files 1172 1170 -2
Lines 74950 75321 +371
===============================================================================
+ Hits 59492 59947 +455
+ Misses 15458 15374 -84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
091707b to
5f54987
Compare
fedemkr
left a comment
There was a problem hiding this comment.
Looks good, the only doubt I have is the same as Claude here https://github.com/bitwarden/ios/pull/2909/changes#r3707928082 on the Share extension.
🎟️ Tracking
PM-40460
📔 Objective
Enforce the new restrict Send type option of the Send Controls policy (
pm-31885-send-controls). When an organization restricts Send creation to a single type, non-owner/non-admin members should only be able to create that type — with no chooser to pick text vs. file — and the "Types" filter should disappear from the Send list.The policy is delivered on the existing
sendControlspolicy via a newallowedSendTypesdata key: an array ofSendTyperaw values (0= text,1= file).[0, 1](or a missing key) means both types are allowed;[0]restricts to text-only and[1]to file-only. This builds directly on the consolidatedSendPolicyOptions(#2877) and the access-control enforcement added in #2906.📸 Screenshots
send.text.only.mov
send.file.only.mov
send.both.mov